Re: [boost][int128] Formal Review Begins Today (July 22-July 31)

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--===============6001667714623818842==
Content-Type: multipart/signed; protocol="application/pgp-signature";
 micalg=pgp-sha512;
 boundary="------6d654df79e66e40795819ae82af417d43bbfc8aad6965d3acbb6d1fd0e194f5d";
 charset=utf-8

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------6d654df79e66e40795819ae82af417d43bbfc8aad6965d3acbb6d1fd0e194f5d
Content-Type: multipart/mixed;boundary=---------------------c6fc185ac5ec0694017f776765822600

-----------------------c6fc185ac5ec0694017f776765822600
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;charset=utf-8





On Monday, July 27th, 2026 at 8:49 AM, John Maddock via Boost <boost@lists=
.boost.org> wrote:

> First off many thanks to Matt for contributing this library, this is a
> fairly quick "drive by" review, hopefully others will delve deeper,
> although as noted below that's hardly needed, given that the interface
> is pretty much fixed ahead of time.
> =


> > Other questions you might want to answer in your review are:
> >    - What is your evaluation of the design?
> =


> It's an integer, there's not much to discuss to be honest. Indeed for an
> integer type, it's almost overly-feature complete, but complaining about
> that is churlish to be honest.
> =


> One random question: I wonder if any consideration was given to making
> integers with checked or saturating operations separate types?  I
> appreciate that this is NOT the way the standard has gone, but it looks
> useful to me, maybe that's a whole other library though?  Likewise while
> we're on the subject of providing a poly-filler, some of the algorithms
> (<numeric> for example) could usefully be extended to all the integer
> types (as per C++26), but again that looks like another library to me.
> =



I have had the same thoughts, and that library can be found here: https://=
github.com/cppalliance/safe_numbers. As always, I would appreciate hearing=
 your thoughts on that one.

> While on the subject of completeness, I'm pleased to see device support
> (CUDA/Sycl) straight out of the box.  This is not necessarily a question
> for Matt, but I'm wondering if there might be any good example
> algorithms that would make use of this and provide some kind of
> benchmark and/or indication of when using parallel computing is actually
> useful?
> =



Yes, I can improve this section. The initial reason for GPU support was to=
 get Boost.Decimal working on GPU (CUDA support will ship in the next Boos=
t release in a few weeks). CUDA somewhat recently added a 128-bit integer =
support to their platform so they must have some level of demand. SYCL and=
 spir64 have no such support. =



> >    - What is your evaluation of the implementation?
> Only a very quick look, but Matt knows what he's doing, and this library
> has been used out in the wild for a while now.
> >    - What is your evaluation of the documentation?
> Excellent and very easy to read.
> >    - What is your evaluation of the potential usefulness of the librar=
y?
> =


> What can I say, in some ways this is a poly-filler library which may not
> be needed... or may be essential depending on your platform/compiler.
> =


> In any case I vote to ACCEPT this library.
> =


> I hope others will take the time to look through this too.
> =


> Best, John Maddock.

Thank you for taking the time to review John.

Matt
-----------------------c6fc185ac5ec0694017f776765822600
Content-Type: application/pgp-keys; filename="publickey - [email protected] - 0xC1382EAD.asc"; name="publickey - [email protected] - 0xC1382EAD.asc"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="publickey - [email protected] - 0xC1382EAD.asc"; name="publickey - [email protected] - 0xC1382EAD.asc"

LS0tLS1CRUdJTiBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tCgp4ak1FWDJ3Z2RCWUpLd1lCQkFI
YVJ3OEJBUWRBVUhPaDBLcGJaQ3N6aGR2S3p0V2o0QzZGUjFvek1CUUUKd2FCaTNtMlBKSExOSzIx
aGRIUkFiV0YwZEdKdmNteGhibVF1WTI5dElEeHRZWFIwUUcxaGRIUmliM0pzCllXNWtMbU52YlQ3
Q2p3UVFGZ29BSUFVQ1gyd2dkQVlMQ1FjSUF3SUVGUWdLQWdRV0FnRUFBaGtCQWhzRApBaDRCQUNF
SkVGbUJXbFZDRmFXbEZpRUV3VGd1clRjb0h3YmRTYklzV1lGYVZVSVZwYVZXdXdFQTc3cm0KT0E0
VEI2WHhlNnE4Z0k0MmJFSUNNaE15WktTTWNha3ozOS9kallrQkFNSk9HK0lHUUMvZDBuM2RzbDEw
CktnL294WDg4a0ZPMW9QS240L1hXK1RvQnpqZ0VYMndnZEJJS0t3WUJCQUdYVlFFRkFRRUhRT3Nt
bzZ3UgpVdVhSQXZGSWlxbVFrellyUHl2S1lLbmEyejRadG1uVFFNa01Bd0VJQjhKNEJCZ1dDQUFK
QlFKZmJDQjAKQWhzTUFDRUpFRm1CV2xWQ0ZhV2xGaUVFd1RndXJUY29Id2JkU2JJc1dZRmFWVUlW
cGFXVUp3RUE1RzBjClpSbkc1V0dORXJJK3k5MGlRclR2MDJpNEl2aHY3dHdvRmNMRC96d0Evakt5
cHcrdmVoRTk5bUVqMS91SQpFa29ERmxOelFacU5sZGJqUmNQeUk1VUgKPTQ2MlMKLS0tLS1FTkQg
UEdQIFBVQkxJQyBLRVkgQkxPQ0stLS0tLQo=
-----------------------c6fc185ac5ec0694017f776765822600--

--------6d654df79e66e40795819ae82af417d43bbfc8aad6965d3acbb6d1fd0e194f5d
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: ProtonMail

wrsEARYKAG0FgmpnWiUJEFmBWlVCFaWlRRQAAAAAABwAIHNhbHRAbm90YXRp
b25zLm9wZW5wZ3Bqcy5vcmfVo9CSBNDQc6yClHS5jabeAR9Hv4MaoHGlcyey
nPjFjhYhBME4Lq03KB8G3UmyLFmBWlVCFaWlAABClgEAgFbvyQWa3LrCfBVY
cYJbSjKXIJiQcw89B7AWj13kBt8BAK9bfnBTtwujMeAHWOhejVBfQvhy5aN4
krJB8c2TWf0H
=Fyit
-----END PGP SIGNATURE-----


--------6d654df79e66e40795819ae82af417d43bbfc8aad6965d3acbb6d1fd0e194f5d--


--===============6001667714623818842==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Boost mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://lists.boost.org/mailman3/lists/boost.lists.boost.org/
Archived at: https://lists.boost.org/archives/list/[email protected]/message/PONUKMJQVQYNK6J5UTRJB27MIJ7VA6N4/ 

--===============6001667714623818842==--