Re: [boost][int128] Formal Review Begins Today (July 22-July 31)

Dear Boost Community,

If you have not produced a Boost.Int128 Formal Review yet, I would like to
encourage you to do so quickly, as we are nearing closing day. You may ask
me for a review period extension. To help you experiment faster, a Compiler
Explorer link including the latest develop fixes can be found here:
https://godbolt.org/z/axWzhKTvn

Also, Guillaume Dua kindly produced a Formal Review with the verdict:
CONDITIONALLY ACCEPT.

The reviewer made several points, quoted here:

> Design: Beside caveats described hereafter, the API feels intuitive and
simple for common use-cases. constexpr (especially for C++14) and NTTP
support are expected yet great additions too.
> Documentation: https://develop.int128.cpp.al/ looks way better than what
I'm used to with other Boost libraries (before its modernisation). The
search bar and preview are convenient/efficient.
> Testing: Looks very decent.
> Accessibility: The standalone header working on godbolt (compilation
time) is great to experiment fast.

The reviewer raised several bugs/issues that Matt is addressing, that I
summarize here:

1) Inconsistent conversion to bool
2) Preprocessor-directive side effects (headers disable -Wsign-conversion
for the rest of the TU)
3) saturating_mul may have a wrong branch
4) BOOST_INT128_NO_BUILTIN_INT128 gets ignored if/when BOOST_HAS_INT128 is
defined
5) boost::random::traits::make_unsigned<int128_t>::type result in int128_t
6) Ambiguous overload resolutions: __int128 vs. uint128_t
7) boost::int128::uint128_t feels odd to write -> uint128 type nested in a
int128 namespace.

The details of this great review, including numerous snippets and Compiler
Explorer reproducers are available in an issue opened by the reviewer:
https://github.com/cppalliance/int128/issues/476

Guillaume had already raised several bugs about Int128 before his formal
review, and Matt fixed them.

I would like to thank Guillaume and all of previous reviewers for taking
the time to review Candidate Boost.Int128 and for making the Boost
ecosystem better, stronger, safer.

Best wishes,
Arnaud Becheler, Review Manager for Candidate Boost.Int128
_______________________________________________
Boost mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://lists.boost.org/mailman3/lists/boost.lists.boost.org/
Archived at: https://lists.boost.org/archives/list/[email protected]/message/7B46BSQOFCFIZJREMA4E53CH7ZD6HAAN/