Re: [boost][int128] Formal Review Begins Today (July 22-July 31)

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--===============1975227038499552443==
Content-Type: multipart/signed; protocol="application/pgp-signature";
 micalg=pgp-sha512;
 boundary="------8c843dbf7b34d2f78a528b6ea5e599310ada42a16fdcca573fcec58f510a6b7a";
 charset=utf-8

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------8c843dbf7b34d2f78a528b6ea5e599310ada42a16fdcca573fcec58f510a6b7a
Content-Type: multipart/mixed;boundary=---------------------842c54a8a4334b75657ab099bca00e87

-----------------------842c54a8a4334b75657ab099bca00e87
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;charset=utf-8


> =


> One minor quibble I had with the documentation.
> The examples section has a prominent section for libfmt, but I felt that
> std::format should be at least as prominent.
> I was of course reassured to find std::format mentioned in the reference
> section, and it worked just fine, so all good there.
> =



I can add that. Right now it says above the example you can replace all th=
e calls to fmt:: with std:: in the example, but clearly it could be better=
.

> A minor gap I came across was C++23 std::byteswap and related
> endian support.
> Less of a practical concern nowadays, but it would be nice for Boost.Int=
128
> to "just work" there too.
> =



byteswap is currently available: https://develop.int128.cpp.al/bit.html#by=
teswap. As for the endian functions that would be a good addition.

> It seems necessary to use BOOST_INT128_UINT128_C macro to initialise a
> std::array<boost::int128::uint128_t,
> 35>.
> A C++ language constraint?  Certainly could be me doing it "wrong".  (Bu=
t
> it works)
> =



BOOST_INT128_UINT128_C is offered for two reasons. First, is that it is an=
alogous to UINT64_C, etc. that people are already used to. Second, BOOST_I=
NT128_INT128_C can be used to initialize INT128_MIN whereas a literal cann=
ot. =



> I recommend to ACCEPT Boost.Int128, it is a worthwhile addition to the
> boost toolbox, and documented and implemented to a high standard.
> =



Thank you for your review!

Matt
-----------------------842c54a8a4334b75657ab099bca00e87
Content-Type: application/pgp-keys; filename="publickey - [email protected] - 0xC1382EAD.asc"; name="publickey - [email protected] - 0xC1382EAD.asc"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="publickey - [email protected] - 0xC1382EAD.asc"; name="publickey - [email protected] - 0xC1382EAD.asc"

LS0tLS1CRUdJTiBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tCgp4ak1FWDJ3Z2RCWUpLd1lCQkFI
YVJ3OEJBUWRBVUhPaDBLcGJaQ3N6aGR2S3p0V2o0QzZGUjFvek1CUUUKd2FCaTNtMlBKSExOSzIx
aGRIUkFiV0YwZEdKdmNteGhibVF1WTI5dElEeHRZWFIwUUcxaGRIUmliM0pzCllXNWtMbU52YlQ3
Q2p3UVFGZ29BSUFVQ1gyd2dkQVlMQ1FjSUF3SUVGUWdLQWdRV0FnRUFBaGtCQWhzRApBaDRCQUNF
SkVGbUJXbFZDRmFXbEZpRUV3VGd1clRjb0h3YmRTYklzV1lGYVZVSVZwYVZXdXdFQTc3cm0KT0E0
VEI2WHhlNnE4Z0k0MmJFSUNNaE15WktTTWNha3ozOS9kallrQkFNSk9HK0lHUUMvZDBuM2RzbDEw
CktnL294WDg4a0ZPMW9QS240L1hXK1RvQnpqZ0VYMndnZEJJS0t3WUJCQUdYVlFFRkFRRUhRT3Nt
bzZ3UgpVdVhSQXZGSWlxbVFrellyUHl2S1lLbmEyejRadG1uVFFNa01Bd0VJQjhKNEJCZ1dDQUFK
QlFKZmJDQjAKQWhzTUFDRUpFRm1CV2xWQ0ZhV2xGaUVFd1RndXJUY29Id2JkU2JJc1dZRmFWVUlW
cGFXVUp3RUE1RzBjClpSbkc1V0dORXJJK3k5MGlRclR2MDJpNEl2aHY3dHdvRmNMRC96d0Evakt5
cHcrdmVoRTk5bUVqMS91SQpFa29ERmxOelFacU5sZGJqUmNQeUk1VUgKPTQ2MlMKLS0tLS1FTkQg
UEdQIFBVQkxJQyBLRVkgQkxPQ0stLS0tLQo=
-----------------------842c54a8a4334b75657ab099bca00e87--

--------8c843dbf7b34d2f78a528b6ea5e599310ada42a16fdcca573fcec58f510a6b7a
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: ProtonMail

wrsEARYKAG0Fgmpt+B8JEFmBWlVCFaWlRRQAAAAAABwAIHNhbHRAbm90YXRp
b25zLm9wZW5wZ3Bqcy5vcmcvCV3xS7WeUACQUnP4n3bnSEm5DHwIVgKLhoaa
8Spn9xYhBME4Lq03KB8G3UmyLFmBWlVCFaWlAAAtZAD/do6v0Ia8vC29Vzzf
zqZfn7QUQ+eaJgOwRBQlLdNtA4YA/Alji636YHknfQoFofUVPtEwK8jrWDqF
OQZ5OE4h+CsO
=nvSb
-----END PGP SIGNATURE-----


--------8c843dbf7b34d2f78a528b6ea5e599310ada42a16fdcca573fcec58f510a6b7a--


--===============1975227038499552443==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Boost mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://lists.boost.org/mailman3/lists/boost.lists.boost.org/
Archived at: https://lists.boost.org/archives/list/[email protected]/message/6FQIVXWA52DZ2MC2SBVMMUQ7DFDAK2JR/ 

--===============1975227038499552443==--