Re: Multi Mini-Review Begins Today
Matt Borland via Boost <[email protected]>
| Newsgroups | gmane.comp.lib.boost.devel |
|---|---|
| Message-ID | <pNk_dvK73b_VP-QyrJUTxLsZYwTwE1Fd5DqQWkevdKM95q96FWa16Vb3kjJJamaHfJTwxA1JvNFYvx3Snq8yYyn7NguWoLAfq6ZJlUEJcxE=@mattborland.com> |
> > Verdict: I would like to see a better multidimensional array library in > Boost. I would even like to see *this* multidimensional array library > in boost, if it were properly documented with some of the rough edges > filed off. But I can barely see an improvement on the state of the > documentation since the last review. I feel like I spent more time and > effort on this review than the submitter did on the documentation. I > also feel that I have barely scratched the surface in this review. I > didn't even notice that major components (layout_t and extents_t) were > missing from the documentation until halfway through. > > I don't want to outright reject a library that is already conditionally > accepted, especially a library that meets a need I have, but I don't > think the library substantially closer to ready for inclusion in Boost > than the last time I saw it. I therefore vote to CONDITIONALLY ACCEPT > the library, on the condition that every single one of my complaints is > addressed, followed by another review. > > -- > Rainer Deyke - [email protected] > Thank you Rainer for your extensive review. I have converted all of your points into a long task list (98 items) on a Github issue. I also asked Alfredo to speak with Jean-Louis Leroy about the API reference missing many items. Jean-Louis also has uses the Mr. Docs autogenerated API reference on Boost.OpenMethod, but the OpenMethod implementation is clearly more inline with what is needed: https://www.boost.org/doc/libs/latest/libs/openmethod/doc/html/openmethod/reference/boost/openmethod.html Matt _______________________________________________ Boost mailing list -- [email protected] To unsubscribe send an email to [email protected] https://lists.boost.org/mailman3/lists/boost.lists.boost.org/ Archived at: https://lists.boost.org/archives/list/[email protected]/message/SYXNXBJW4HTOAUYFPCMD6XON3MIIX6NI/
publickey - [email protected] - 0xC1382EAD.asc
(application/pgp-keys, 653 B)
-----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX2wgdBYJKwYBBAHaRw8BAQdAUHOh0KpbZCszhdvKztWj4C6FR1ozMBQE waBi3m2PJHLNK21hdHRAbWF0dGJvcmxhbmQuY29tIDxtYXR0QG1hdHRib3Js YW5kLmNvbT7CjwQQFgoAIAUCX2wgdAYLCQcIAwIEFQgKAgQWAgEAAhkBAhsD Ah4BACEJEFmBWlVCFaWlFiEEwTgurTcoHwbdSbIsWYFaVUIVpaVWuwEA77rm OA4TB6Xxe6q8gI42bEICMhMyZKSMcakz39/djYkBAMJOG+IGQC/d0n3dsl10 Kg/oxX88kFO1oPKn4/XW+ToBzjgEX2wgdBIKKwYBBAGXVQEFAQEHQOsmo6wR UuXRAvFIiqmQkzYrPyvKYKna2z4ZtmnTQMkMAwEIB8J4BBgWCAAJBQJfbCB0 AhsMACEJEFmBWlVCFaWlFiEEwTgurTcoHwbdSbIsWYFaVUIVpaWUJwEA5G0c ZRnG5WGNErI+y90iQrTv02i4Ivhv7twoFcLD/zwA/jKypw+vehE99mEj1/uI EkoDFlNzQZqNldbjRcPyI5UH =462S -----END PGP PUBLIC KEY BLOCK-----
signature.asc
(application/pgp-signature, 343 B)
-----BEGIN PGP SIGNATURE----- Version: ProtonMail wrsEARYKAG0Fgmp3ThQJEFmBWlVCFaWlRRQAAAAAABwAIHNhbHRAbm90YXRp b25zLm9wZW5wZ3Bqcy5vcmcclX84O7beSC5L4t5MmFLs5VkNrJI9XQL8UqTj 24C0+BYhBME4Lq03KB8G3UmyLFmBWlVCFaWlAADMSAEAvZDWk7ARLnVOx2fn e38Wj73T0qmUGDvQEitdz8jyZkIBAIOtPr+Bpr8Fwt1SXsIBNzEfWXY/sIbI d4UGia+ixIoB =oM/e -----END PGP SIGNATURE-----