Re: [BoostBook] Support for SVN fixed-length $Date$ keyword
Robert Kawulak <[email protected]> Sat, 13 Jul 2013 13:40:25 +0200
| Newsgroups | gmane.comp.lib.boost.documentation |
|---|---|
| Message-ID | <!&!AAAAAAAAAAAYAAAAAAAAAP2My3EH4FhKr+L7Y/[email protected]> |
> From: Daniel James > I'm not really familiar with this part of the code. Just looking at > the existing code, I want to make some changes. I think I'll modify > the calling code to check for '$Date:' first. Also, the code in > html-help.xsl doesn't seem to be used, so that should just be deleted. > If we ever want to add this to html-help.xsl then it should be from a > shared implementation. But I can do all of that after your patch. I was also wondering why the code is duplicated, but didn't want to touch more than needed not to break something. ;) > Regarding your patch, the "substring-after($text, ' ')" looks fragile > to me, IIUC "substring-after($text, ': ')" should work and be a little > better. Good idea, I've changed that. > Other than that, it seems fine. I'm not familiar with the process and would be grateful for some clues - do I patch the trunk only, or do I also do this in release branch? Thanks and best regards, Robert