Re: [PATCH] gl: fix the same surface bug and cairo_glx_surface_t source surface bug
Chuanbo Weng <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <CAFu4+mV06iyANGDgvCP+kJvUupe27b6bFEhFC+oh49o=RwhW5w@mail.gmail.com> |
So we are going to support operation such as self-copy in gl backend, right? 2012/1/11 Chris Wilson <[email protected]> > On Wed, 11 Jan 2012 22:38:39 +0800, Chuanbo Weng <[email protected]> wrote: > > The drawing error is an issue in the output. The "self-copy" and > > "subsurface" > > I mentioned are the cases in cairo/test/: self-copy.c and subsurface.c. > > So you can check the output pictures, which are incorrect. > > These cases use target surface as their source surface at the same time, > > which > > cause the render output incorrect. (When you bind one image from a > texture > > to an > > FBO, and If you do try to read and write to the same image, you get > > undefined > > results.) > > And it is equally undefined in cairo at the moment. The self-copy test is > there more to capture how each backend behaves. The consensus has been > towards always performing a snapshot on the source before every > operation (and optimising away that snapshot for the common case where > it is irrelevant). > > Does anyone have any objections for cairo to start treating all sources > as immutable even when source == destination? > -Chris > > -- > Chris Wilson, Intel Open Source Technology Centre > -- cairo mailing list [email protected] http://lists.cairographics.org/mailman/listinfo/cairo