Re: [patch] gl - use direct mode for uploading gradient texture
Chris Wilson <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <[email protected]> |
On Tue, 20 Mar 2012 00:32:01 +0000, "Henry (Yu) Song - SISA" <[email protected]> wrote: > Using pbo to upload gradient fails on ATI/fglrx driver (latest 12.2). glGetError () after glTexSubImage2D() always returns GL_INVALID_OPERATION. Not sure why, might be fglrx bug. PBO works for other drivers. > To make it work in ATI/flgrlx, I have attached the following patch. Figured that since gradient is small, non-pbo performance hit should be minimal. If you think that cairo should keep pbo and let fglrx fails until they fix bugs. I am fine with that. Using a pbo is not going to be performance critical, so lets just drop it in order to have simpler code. I amended your patch to improve the error handling and pushed, thanks. -Chris -- Chris Wilson, Intel Open Source Technology Centre -- cairo mailing list [email protected] http://lists.cairographics.org/mailman/listinfo/cairo