Re: [PATCH 3/4] test: Only use alarm() when SIGALRM is also defined

Hi,

On 09.04.2012 21:33, Maarten Bosmans wrote:
> On some platforms (mingw) the alarm() configure check succeeds, but the
> alarm function doesn't actually work.
> ---
>  test/cairo-test.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/test/cairo-test.c b/test/cairo-test.c
> index c5ef843..3f37147 100644
> --- a/test/cairo-test.c
> +++ b/test/cairo-test.c
> @@ -90,7 +90,7 @@
>  #define ARRAY_SIZE(A) (sizeof(A) / sizeof (A[0]))
>  #endif
>  
> -#if ! HAVE_ALARM
> +#if ! HAVE_ALARM || ! defined(SIGALRM)
>  #define alarm(X);
>  #endif

What exactly does "doesn't actually work" mean? If no SIGALRM is raised (in
other words: alarm() doesn't actually work and is a no-op), then what is the
problem that this patch solves?

Besides that, this series looks good to me.

Uli
-- 
"Do you know that books smell like nutmeg or some spice from a foreign land?"
                                                  -- Faber in Fahrenheit 451
--
cairo mailing list
[email protected]
http://lists.cairographics.org/mailman/listinfo/cairo