Re: Quartz regression in release 1.12
Andrea Canciani <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <CAN_5=BApwyEazYFizzDDuCZde04NNTVkGUHvttuPOzwymUhLZQ@mail.gmail.com> |
On Mon, Apr 23, 2012 at 3:57 AM, cu <[email protected]> wrote: > The branch also seems to work on iOS/armv7 - did not crash yet :), and > renders properly. > > I do get the following error from time to time in the log: > <Error>: CGImageCreate: invalid image bits/pixel or bytes/row. > > Nothing seems to be visibly broken when that happens, but I wonder what > it means? I already have a (partial) fix for it, but it's still wip. If you want to try it, apply the attachment. Andrea > > >> Ok, I'm quite confident that this means that you're not on the >> wip/map-quartz branch. >> Please check if 'git branch' returns a list of branches with >> 'wip/map-quartz' starred. >> If not, please do 'git checkout wip/quartz-map', rebuild and test again. >> (Fixing this issue with the mapping is exactly the purpose of the >> wip/map-quartz branch). >> Another way to check if you're on the right branch is to check if the >> current state is 'git log'. It should show a list of commits and the >> first one should be 6021ff13f5e7d8ab0b9692cf36ee055c45530134. >> >> Andrea >> >> > -- cairo mailing list [email protected] http://lists.cairographics.org/mailman/listinfo/cairo
0001-clip-map-extents.patch
(application/octet-stream, 1.2 KB)
From a4c019389485eed06577e91427e617079bafa791 Mon Sep 17 00:00:00 2001 From: Andrea Canciani <[email protected]> Date: Sat, 14 Apr 2012 09:12:29 +0200 Subject: [PATCH 1/2] clip map extents --- src/cairo-quartz-surface.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cairo-quartz-surface.c b/src/cairo-quartz-surface.c index 3a07698..e327944 100644 --- a/src/cairo-quartz-surface.c +++ b/src/cairo-quartz-surface.c @@ -776,7 +776,7 @@ static void DataProviderReleaseCallback (void *info, const void *data, size_t size) { quartz_source_image_t *source_img = info; - _cairo_surface_unmap_image (source_img->surface, source_img->image_out); + cairo_surface_unmap_image (source_img->surface, source_img->image_out); free (source_img); } @@ -814,7 +814,7 @@ _cairo_surface_to_cgimage (cairo_surface_t *source, source_img->surface = source; - source_img->image_out = _cairo_surface_map_to_image (source_img->surface, extents); + source_img->image_out = cairo_surface_map_to_image (source_img->surface, extents); if (unlikely (source_img->image_out->base.status)) { free (source_img); return status; -- 1.7.7.5 (Apple Git-26)