Re: [PATCH] gl: Fix bug in render_glyphs_via_mask().

Chuanbo Weng <[email protected]>
Newsgroups gmane.comp.lib.cairo
Message-ID <CAFu4+mV2HH17q2mFPR_addQhNjvMKHp9yOtOyjkN0=-Zq+E=5g@mail.gmail.com>
agree with you.
I saw the patch you committed:
185a3518968d5ca0babb798fe10f247171a1e001
Just a slight modification is needed, I think:
The dst_x and dst_y should be considered when
trimming the mask.

2012/6/20 Chris Wilson <[email protected]>

> On Wed, 20 Jun 2012 04:04:43 +0800, Chuanbo Weng <[email protected]> wrote:
> > If the operator is unbounded and mask is not large enough, the area
> > affected by _cairo_surface_mask() in render_glyphs_via_mask() will
> > be too larger, then result in output error. Fixes overlapping-glyphs
> > and unbounded-operator test cases in cairo-test-suite.
>
> Whoops, the error here is that we have begun to pass in a NULL clip to
> _cairo_surface_mask(), which as you can see has the effecting of
> clearing everything outside of the masked region.
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
>

-- 
cairo mailing list
[email protected]
http://lists.cairographics.org/mailman/listinfo/cairo
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.