Re: [PATCH] gl: Fix bug in render_glyphs_via_mask().
Chris Wilson <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <1340701437_74917@CP5-2952> |
On Tue, 26 Jun 2012 16:06:00 +0800, Chuanbo Weng <[email protected]> wrote: > agree with you. > I saw the patch you committed: > 185a3518968d5ca0babb798fe10f247171a1e001 > Just a slight modification is needed, I think: > The dst_x and dst_y should be considered when > trimming the mask. Yes, I do believe you are right. Since dst may no longer be info->surface, and so require the offset. Can you see if that fixes any test cases, or devise one to exercise this failure path? It should be required for a clipped source/unbounded operation. -Chris -- Chris Wilson, Intel Open Source Technology Centre -- cairo mailing list [email protected] http://lists.cairographics.org/mailman/listinfo/cairo