Re: [PATCH] gl: return unsupported if the source surface type is gl-window in upload_boxes()
Chris Wilson <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <1342113662_1942@CP5-2952> |
On Thu, 12 Jul 2012 16:44:19 +0800, Chuanbo Weng <[email protected]> wrote: > When the source surface type is gl-window in upload_boxes(), return > unsupported. Together with the patch I sent just now, fixes 8 fails > in cairo-test-suite. Try to avoid adding single purpose functions to the general surface layer. At that level, we should only have functions that apply to all types of raster and paginated surfaces. It looks like we could achieve the desired effect with the check pushed down into _cairo_gl_spans_compositor::copy_boxes(). So I pushed a different patch, can you please look it over. Thanks for the couple of patches, -Chris -- Chris Wilson, Intel Open Source Technology Centre -- cairo mailing list [email protected] http://lists.cairographics.org/mailman/listinfo/cairo