Re: [PATCH 1/2] xlib: Don't crash when swapping a 0-sized glyph
Adam Jackson <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <1353101227.21005.67.camel@atropine> |
On Fri, 2012-11-16 at 19:59 +0100, Uli Schlachter wrote: > I haven't forgotten this patch. However, I have no clue what the original > "server crashes on 0x0 glyphs" bug is about nor if we want to keep the > work-around for that. My hope is that the almighty Chris could help us here. The original server bug was this, I believe: http://cgit.freedesktop.org/xorg/xserver/commit/render/render.c?id=622fc98fd08aba98369e6933c3ab8c9ff85385d5 ~/xserver% git describe --contains 622fc98fd08aba98369e6933c3ab8c9ff85385d5 xorg-server-1.7.99.1~63 _cairo_xlib_traps_compositor_get() gets called if the render version is >= 0.4; given that 0.5 was when ARGB cursors were added, that's somewhere back in the XFree86 era. So presumably this path is indeed broken for sufficiently old xserver. Naughty, introducing a regression like that. I can come up with a testcase I suppose, but it will likely be sometime after the upcoming holiday as I'll be travelling a bit. - ajax -- cairo mailing list [email protected] http://lists.cairographics.org/mailman/listinfo/cairo
signature.asc
(application/pgp-signature, 198 B)
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEABECAAYFAlCmr6sACgkQW4otUKDs0NNmaACghL6vv56aaC5zDMEllPP7ctVD OgYAnjvnQ2DGoMK/JuX9eq33O/FeY7rU =Mh5T -----END PGP SIGNATURE-----