Re: [PATCH 1/2] stroke: Fix large line widths for fallback stroke shaper
Chris Wilson <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Mar 13, 2013 at 05:19:19PM -0700, Martin Robinson wrote: > On 03/13/2013 04:57 AM, Chris Wilson wrote: > > Hmm, can you do this as a separate patch. Preferably with another to try > > and fix the current code before replacing it. As you should be able to > > avoid the division to check the intersection against [0,1] so I want a > > closer look at what you consider the bug to be. > > Sure, I think that the attached patch fixes the intersection code. > If that's correct we can keep both the slow version (floating point) > and the fast version (fixed point) around. > > > commit c3042c097e1a508fc56c87781cb72096ee735833 > Author: Martin Robinson <[email protected]> > Date: Wed Mar 13 17:08:23 2013 -0700 > > path: Fix a bug in line intersection > > Before the intersection code was not taking into account that both > quotients are required to be in the range (0,1) for the segments to > intersect or handling the case of negative numerators and denominators. D'oh. Yes, that's definitely an oversight I should have picked up. Patch looks like it does what you want. -Chris -- Chris Wilson, Intel Open Source Technology Centre -- cairo mailing list [email protected] http://lists.cairographics.org/mailman/listinfo/cairo