Re: Small suspected buglet in XML surface code

On Fri, Jun 21, 2013 at 09:49:01AM +0200, Edward Zimmermann wrote:
>    cairo-xml-surface.c
>     
>     
>     
>     
>    One checks here for NULL.. but
>     
>    static cairo_status_t
>    _cairo_xml_surface_emit_clip (cairo_xml_surface_t *surface,
>                                  const cairo_clip_t *clip)
>    {
>        if (clip == NULL  ||  clip->path == NULL) /* < -- edz: added  check
>    for clip->path */
>            return CAIRO_STATUS_SUCCESS;
>     
>        return _cairo_xml_surface_emit_clip_path (surface, clip->path);
>    }
>     
>    Only checks if the clip is NULL but clip->path can be, I think, NULL too!


commit 5589e80e2bd6b82e5730cbf6b72aaf82a66b31c0
Author: Chris Wilson <[email protected]>
Date:   Fri Jun 21 12:01:32 2013 +0100

    xml: Handle clip-boxes in the updated cairo_clip_t
    
    Edward Zimmermann pointed out that the xml surface had bitrotted slightly
    and no longer understand the new clip layout - in particular that we can
    have clips without a path, but just with boxes instead.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
-- 
cairo mailing list
[email protected]
http://lists.cairographics.org/mailman/listinfo/cairo