Bad reference images for build test suite
"Bryce W. Harrington" <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <5A5FB412583EA944A1D0228D52A9C572639ECC@sisaex02sj> |
Last week psychon mentioned some doubts about the correctness of reference images in the test suite, so I've been poking through them the past few days. I'm still coming up to speed so it's tough to identify the problems, but the pdf references for the huge-radial test are clearly bogus: https://bugs.freedesktop.org/show_bug.cgi?id=66218 A patch to delete the two bad images is here: https://bugs.freedesktop.org/attachment.cgi?id=81489 (Linking rather than attaching because the patch is big, and just comprises encoded binary gunk so isn't really reviewable. Please let me know I should rather be posting these to the list.) I've written up a post with my understanding of how the reference images work in the test suite; I've glossed some details for brevity, but please correct me on any points I've misunderstood: http://www.bryceharrington.org/wordpress/2013/06/cairo-testsuite-reference-image-cleanup-2/ Along with this, I'm also working on a tool to identify redundancies and discrepancies amongst the reference images, which I'll post soonish. I've been trying to use it to spot test cases which would un-break if we removed certain reference images, but haven't yet had much luck: Some reference images differ within the pdiff threshold and still PASS either way; others (like the above) look different but are still FAILing anyway. -- Bryce Harrington Senior Open Source Developer - [email protected] Open Source Group - Samsung Research America -- cairo mailing list [email protected] http://lists.cairographics.org/mailman/listinfo/cairo