[PATCH 0/7] Add check-ref-dups

This patchset adds a script to locate redundant reference images that
can safely be dropped from the tree without affecting test results.

I've hooked this into 'make check-ref-dups' - which already existed in
the makefile but had bitrotted and no longer worked.  The original
code was not descriminating enough; it included far too many false
positives to be of much use.  However, the first change of this patchset
fixes the bitrot so the original code can be run.  The subsequent
patches remove it in favor of the new checker.

The new checker only suggests removing files for which make check will
fall back to an equivalent more generic image.  Currently this flags 1485
image files (approx. 30 mb in an unpacked tarball).

Running make check on the codebase (with default configuration) with the
redundant images removed produces essentially the same test results:

# Before
#######
# Tests run:        13687
# Passed:           9216
# Failed:           3566
# Expected Failed:  312
# Error:            1
# Crashed:          17
# Untested:         575
# Total:            13687
#######

# After
#######
# Tests run:        13689
# Passed:           9216
# Failed:           3566
# Expected Failed:  312
# Error:            1
# Crashed:          19
# Untested:         575
# Total:            13689
#######

The two additional crashes in the latter run are just due to irregular
crashes in the pthread-same-source test cases, which alternate between
crashing and failing randomly.


Bryce Harrington (7):
  test: Fix make check-ref-dups due to move of ref images to reference/
  test: Add script to check for redundant reference images
  test: Use cmp to catch byte-by-byte identical files
  test: Make check-ref-dups utilize perceptualdiff for comparisons
  pdiff: Quell warning about signed/unsigned comparisons
  pdiff: Drop unused variable
  test: Add special cases for create-from-png and fallback-resolution

 test/Makefile.am            |    9 +++---
 test/check_refs.sh          |   74 +++++++++++++++++++++++++++++++++++++++++++
 test/pdiff/perceptualdiff.c |    6 ++--
 3 files changed, 82 insertions(+), 7 deletions(-)
 create mode 100755 test/check_refs.sh

-- 
1.7.9.5


--
Bryce Harrington
Senior Open Source Developer  -  [email protected]
Open Source Group             -  Samsung Research America

-- 
cairo mailing list
[email protected]
http://lists.cairographics.org/mailman/listinfo/cairo