Re: [PATCH 2/2] test: Fix several tests to place output files in the output directory
"Bryce W. Harrington" <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <[email protected]> |
On Sat, Aug 10, 2013 at 08:44:32PM +0200, Uli Schlachter wrote: > > -#define BASENAME "create-for-stream.out" > > +#define BASENAME "output/create-for-stream.out" > > I don't really like this. > > We already have a define CAIRO_TEST_OUTPUT_DIR for "output" which is only used > in three places, all of them using it like > _cairo_test_mkdir(CAIRO_TEST_OUTPUT_DIR). I guess this means that this patch > would need something equivalent. Thanks for the feedback. I've forwarded an updated patchset which uses this define, and which creates the output dir if needed on a per-test basis. I haven't tested running the tests from a rel path, so there might be other issues but at least the dir will be created in this case. Bryce -- cairo mailing list [email protected] http://lists.cairographics.org/mailman/listinfo/cairo