Re: [PATCH v3 0/7] test: Don't ignore test output files when written to the wrong directory
"Bryce W. Harrington" <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <[email protected]> |
On Sun, Sep 08, 2013 at 08:00:59PM +0200, Uli Schlachter wrote: > Hi, > > On 08.09.2013 19:46, Bryce W. Harrington wrote: > > On Sun, Sep 08, 2013 at 03:03:18PM +0200, Uli Schlachter wrote: > [...] > >>> test: Make cairo_test_mkdir() usable throughout tests > >> > >> Why does this copy&paste _cairo_test_mkdir() to cairo_test_mkdir()? Wouldn't it > >> be enough to rename _cairo_test_mkdir() and make it non-static (and adding it to > >> cairo-test.h)? > > > > _cairo_test_mkdir() is implemented in indivdual tests. This commit > > places it in the core test code so other tests can link to it. You > > can't just rename one of the existing routine implementations. > [...] > > Uhm, that patch adds it to cairo-test.c, around line 1791. Right now, we have an > identical implementation called _cairo_test_mkdir() at line 107 in that file. > (Although I have to admit that I mixed this up and thought some other patch > removed that _cairo_test_mkdir() implementation. I should have been clearer, sorry.) Ok, you're right, I didn't notice that, I suck. Bryce -- cairo mailing list [email protected] http://lists.cairographics.org/mailman/listinfo/cairo