Re: [PATCH 4/8] xml: Don't assert on unsupported mesh and raster source patterns
Chris Wilson <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <[email protected]> |
On Sat, Feb 22, 2014 at 02:07:06AM +0000, Bryce W. Harrington wrote: > This quells the following warnings: > > src/cairo-xml-surface.c:722:5: warning: enumeration value > ‘CAIRO_PATTERN_TYPE_MESH’ not handled in switch > src/cairo-xml-surface.c:722:5: warning: enumeration value > ‘CAIRO_PATTERN_TYPE_RASTER_SOURCE’ not handled > in switch > > I didn't find matching routines to handle these recently added enums, so > gather they're unsupported in xml. But we probably shouldn't crash if > they're present. No. The warning is telling us to implement the missing code, not to simply silence it. The assert is so that someone will eventually complain. -Chris -- Chris Wilson, Intel Open Source Technology Centre -- cairo mailing list [email protected] http://lists.cairographics.org/mailman/listinfo/cairo