Re: [PATCH] Minor fixes in the new downscaling code.
Krzysztof Kosiński <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <CAFLw2WRtiUM6pLKYs36GJft1pRqydeG6ZSjjXXVFrGqE03VJ5Q@mail.gmail.com> |
2014-02-07 22:45 GMT+01:00 Bryce W. Harrington <[email protected]>: > On Wed, Feb 05, 2014 at 01:32:02AM +0100, Krzysztof Kosiński wrote: >> The test suite actually contains only one test for downscaling and >> it's not testing the different filters. > > The test includes test cases for fast, good, best, nearest, and bilinear > filters, each at three different levels of resolution. The intention is > that it should test all of the different filters, so if it isn't please > indicate what it's missed. (And ideally, include updates to the test > with your patch so we can improve its coverage). Resurrecting an old thread: The test case (pixman-downscale.c) did not catch the error, because the result happens to be exactly the same with and without proper downscaling. I will modify this test case so that there is some difference. Regards, Krzysztof -- cairo mailing list [email protected] http://lists.cairographics.org/mailman/listinfo/cairo