Re: [PATCH] test : Maintain consistency in the usage of xcalloc

RAVI NANJUNDAPPA <[email protected]>
Newsgroups gmane.comp.lib.cairo
Message-ID <[email protected]>
Hi,

I've done the basic build test with the changes and the build works fine.

I've also tried to execute "negative-stride-image" and "stride-12-image" tests with and without these changes.

In both the scenarios the results are same.

Thanks and Best Regards,

N Ravi

------- Original Message -------

Sender : RAVI NANJUNDAPPA<[email protected]> Technical Lead/SRI-Bangalore-TZN/Samsung Electronics

Date : May 06, 2014 15:44 (GMT+05:30)

Title : [PATCH] test : Maintain consistency in the usage of xcalloc

xcalloc is a wrapper for calloc. If it can't allocate memory then it
terminates the program. The current changes replace the usages of calloc
by xcalloc in tests.

Signed-off-by: Ravi Nanjundappa
---
test/negative-stride-image.c | 2 +-
test/stride-12-image.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/negative-stride-image.c b/test/negative-stride-image.c
index a407b8c..dfc8d64 100644
--- a/test/negative-stride-image.c
+++ b/test/negative-stride-image.c
@@ -41,7 +41,7 @@ draw (cairo_t *cr, int width, int height)
png = cairo_test_create_surface_from_png (ctx, png_filename);

stride = cairo_format_stride_for_width (format, width);
- data = calloc (stride, height);
+ data = xcalloc (stride, height);
inv = cairo_image_surface_create_for_data (data + stride * (height - 1),
format, width, height, -stride);

diff --git a/test/stride-12-image.c b/test/stride-12-image.c
index 21bd8b0..5650e98 100644
--- a/test/stride-12-image.c
+++ b/test/stride-12-image.c
@@ -41,7 +41,7 @@ draw (cairo_t *cr, int width, int height)
png = cairo_test_create_surface_from_png (ctx, png_filename);

stride = cairo_format_stride_for_width (format, width) + 12;
- data = calloc (stride, height);
+ data = xcalloc (stride, height);
src = cairo_image_surface_create_for_data (data, format,
width, height, stride);

--
1.7.9.5

-- 
cairo mailing list
[email protected]
http://lists.cairographics.org/mailman/listinfo/cairo
201405061552525_QKNMBDIF.gif (image/gif, 13.7 KB) - not displayed
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.