Re: [PATCH] skia: update the source to build with the latest skia
"Bryce W. Harrington" <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Jun 25, 2014 at 05:01:22PM +0530, RAVI NANJUNDAPPA wrote: > Hi, > > Please my comments inline below. > > -----Original Message----- > > From: cairo [mailto:[email protected]] On Behalf Of Uli > > Schlachter > > Sent: Wednesday, June 25, 2014 1:29 PM > > To: [email protected] > > Subject: Re: [cairo] [PATCH] skia: update the source to build with the > latest > > skia > > > > Hi, > > > > since Bruce (:-P) wants me to complain, here are my complaints: Thanks for reviewing! > > Is it somehow possible to check the required minimum Skia version during > > configure? Mostly just for documentation purpose? > > AFAIK, the latest skia is still at 1.0.0 version (as mentioned in > include/core/SkTypes.h file skia source dir). > Yes, we can check for the minimum required Skia version during configure. The Skia project doesn't do releases, and so does not have any version numbers. We can identify the git SHA we based our support on, but that's about it. I don't know when version 1.0.0 was declared but I think it was a long, long time ago, so testing it in our configure is not going to be useful. > > And Skia really doesn't have anything like a stable API? :-( > > > > Yes. In my experience, Skia APIs are changing very rapidly. Not sure of the > reason though. Whereas Cairo aims to be a general purpose library used by everyone, Skia's development mainly just focuses on its use by one program - Chromium. Because of this, API stability is not a priority for them. (I think this is the same reason they don't do releases.) > > > > Note that I have no clue about skia and will not give my Reviewed-by to > any > > patches touching it. The above is just what I noticed from a quick look. > > Thanks for your comments. I'll try to look at these and re-submit the patch > again with relevant changes, wherever necessary. > I hope that should be fine. Sounds good. I'll wait on pulling the patch for now. Bryce -- cairo mailing list [email protected] http://lists.cairographics.org/mailman/listinfo/cairo