Re: [PATCH] xcb: make use of _cairo_surface_is_xcb to check for surface type

On 02.07.2014 10:46, RAVI NANJUNDAPPA wrote:
> Hi, 
> 
> Please find attached the updated patch incorporated with review comments
> from Uli. 
> Thanking him for taking time to review the patch. 
> Please help me in reviewing the attached patch.
> 
> Thanks and Best Regards, 
> N Ravoi
> 
[...]

With one minor comment:

Reviewed-by: Uli Schlachter <[email protected]>

> diff --git a/src/cairo-xcb-surface.c b/src/cairo-xcb-surface.c
> index c900edc..3b0c422 100644
> --- a/src/cairo-xcb-surface.c
> +++ b/src/cairo-xcb-surface.c
> @@ -1432,7 +1432,7 @@ cairo_xcb_surface_set_size (cairo_surface_t *abstract_surface,
>      }
>  
>  
> -    if (abstract_surface->type != CAIRO_SURFACE_TYPE_XCB) {
> +    if (!_cairo_surface_is_xcb(abstract_surface)) {
>  	_cairo_surface_set_error (abstract_surface,
>  				  _cairo_error (CAIRO_STATUS_SURFACE_TYPE_MISMATCH));
>  	return;

Here (and in the other change in cairo-xcb-surface.c) it should be "( !" instead
of "(!". Just to match the normal cairo coding style.

Uli
-- 
Homophobia - The fear that another man will treat you the way you treat women.
-- 
cairo mailing list
[email protected]
http://lists.cairographics.org/mailman/listinfo/cairo