Re: Patch for win32 clipping crash + Visual Studio project file

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 24.07.2014 18:52, LRN wrote:
> On 09.07.2014 1:43, Bryce W. Harrington wrote:
>> On Tue, May 20, 2014 at 06:16:23PM +0200, z wrote:
>>> Hi, I'm new here, please tell me if I write anything inappropriate to 
>>> this list.
>>> 
>>> As others before me I also met a crash using cairo with a win32 dc
>>> when it has clipping. For example: 
>>> http://lists.cairographics.org/archives/cairo/2012-October/023683.html
>>>
>>>
>>> 
It took me a few hours but I figured out what the problem is. I don't
>>> know how to post patches (i.e. just add attachment or something) so
>>> let me paste in the diff output. (it was done with the source of the
>>> latest stable release, 1.12.16)
>>> 
>>> The original code could be optimized to work faster with smaller
>>> memory usage as it is currently not really optimal, but I don't have
>>> the time to do it. If anyone wants to, I might be able to help after I
>>> spent so much time reading this code to make the patch. (Currently it
>>> is better to just allocate some memory and let cairo write to it
>>> directly.)
>>> 
>>> I also made a project file that works with Visual Studio 2012 (and 
>>> presumably 2013) and compiles the pixman 0.32.4  / cairo 1.12.16 into
>>> a static library without having to install other tools: 
>>> http://sourceforge.net/projects/cairosolutionvs2012/
>>> 
>>> Here's the patch: (I don't know if the format is good, I used
>>> winmerge to make it, but looks very similar to other patches)
> 
>> Here's a document with some directions on how to properly format
>> patches:
> 
>> http://wiki.x.org/wiki/Development/Documentation/SubmittingPatches/
> 
>> Basically, you should generate them via `git format-patch`
> 
> Since the OP seems to be absent, here's a beautified version of the same 
> patch, with suggested changes.
> 

There's a typo in the patch (one comma is missing, my bad - that's what
happen when you commit code without testing whether it compiles or not).

Anyway, the code itself doesn't work for me - GTK+, when using a version of
cairo patched like this, fails to draw anything (all windows are empty).

So if you guys were concerned in any way that you're missing on anything -
don't be.

- -- 
O< ascii ribbon - stop html email! - www.asciiribbon.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (MingW32)

iQEcBAEBAgAGBQJT0fGyAAoJEOs4Jb6SI2Cw/VEIAMZIhpK6Q+ujJwMHBCXiZ+NI
3P7zdOxwdvkYLcUyuePZsdzVOAPLlchcfrwACUxslallsY3JGf090PGjEZ6a0krB
UE+xKx9qB0BS2cCdEE3dcpnSxDVaZhtdPWd26o351j82G4KqXKebYqpJ70mwNabj
JkJ3KclVtIUoKBRwb49Blmts4+eDIh9MsT9CYyuejn/kdJkLBX19j9apM4V8VNyP
s1Jd258rrM3ahj+QQbW5WLZIqxc6W5VpLjHz1jmleRj1ljVf22j+iJ1e+DsJUFF1
MTKulcOl+fyWxM+CH2gn7OdSkkX0pf7LxYZzeAZgpqqwXNrL2Y+um0l46w7WEWI=
=Y3kF
-----END PGP SIGNATURE-----
-- 
cairo mailing list
[email protected]
http://lists.cairographics.org/mailman/listinfo/cairo