Re: [PATCH] Fix width and height args for _cairo_xcb_connection_copy_area()
RAVI NANJUNDAPPA <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <[email protected]> |
Hi, > -----Original Message----- > From: cairo [mailto:[email protected]] On Behalf Of Bryce > Harrington > Sent: Thursday, August 21, 2014 3:05 AM > To: Maks Naumov > Cc: [email protected] > Subject: Re: [cairo] [PATCH] Fix width and height args for > _cairo_xcb_connection_copy_area() > > On Wed, Aug 20, 2014 at 06:29:13PM +0300, Maks Naumov wrote: > > Uli writes: > > > Ouch. How did you find this? Any particular test case that catches this? > > Static analysis. > > Yeah, we really should be running some of the static analysis tools alongside > the test suite. > I tried to search for open source static analysis tools for C/C++ code (https://en.wikipedia.org/wiki/List_of_tools_for_static_code_analysis) . I found one tool called cppcheck, which is very useful. If you are using Ubuntu machine, you can install the "cppcheck" pkg and use the tool. Few minutes back, I started exploring the tool with Cairo source and found some errors reported by the tool. Fixed them and sent the patch for review. Please check it. > It'd be nice to also have a slimmed down version of the perf tests that will > complete in a reasonable amount of time. > > Anyone know if there are existing CI systems that are already running Cairo > or would be willing to add us and share results regularly? > > Bryce > > > -- > cairo mailing list > [email protected] > http://lists.cairographics.org/mailman/listinfo/cairo -- cairo mailing list [email protected] http://lists.cairographics.org/mailman/listinfo/cairo