Re: [PATCH] src and test: Fix issues reported by cppcheck static analysis tool
Chris Wilson <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <[email protected]> |
On Thu, Aug 21, 2014 at 03:21:35PM +0530, Ravi Nanjundappa wrote: > cppcheck analysis tool reports the following issues when run on the > latest Cairo source. > $ grep "(error)" cppcheck_error_log.txt > [src/skia/cairo-skia-surface.cpp:245]: (error) Memory leak: surface > [test/pdf-mime-data.c:58]: (error) Possible null pointer dereference: file - otherwise it is redundant to check if file is null at line 53 > [test/pdf-mime-data.c:75]: (error) Resource leak: fp > $ > > The proposed changes fixes the above issues. > > Signed-off-by: Ravi Nanjundappa <[email protected]> Split it up into patches, and then you can add my Reviewed-by: Chris Wilson <[email protected]> -Chris -- Chris Wilson, Intel Open Source Technology Centre -- cairo mailing list [email protected] http://lists.cairographics.org/mailman/listinfo/cairo