Re: [PATCH] Fix width and height args for _cairo_xcb_connection_copy_area()
Bryce Harrington <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Aug 20, 2014 at 04:42:55PM -0500, Mike Steinert wrote: > On Wed, Aug 20, 2014 at 4:35 PM, Bryce Harrington <[email protected]> wrote: > > On Wed, Aug 20, 2014 at 06:29:13PM +0300, Maks Naumov wrote: > >> Uli writes: > >> > Ouch. How did you find this? Any particular test case that catches this? > >> Static analysis. > > > > Yeah, we really should be running some of the static analysis tools > > alongside the test suite. > > > > It'd be nice to also have a slimmed down version of the perf tests that > > will complete in a reasonable amount of time. > > > > Anyone know if there are existing CI systems that are already running > > Cairo or would be willing to add us and share results regularly? > > Have you considered Coverity Scan? [1] I believe it's free for open > source projects. Looks like someone's already registered Cairo with Coverity, although I don't have an account so don't know what's there: https://scan.coverity.com/projects/1040 I've used coverity for other projects in the past. I recall being impressed that they provided good documentation along with the errors, which made it obvious what needed changed. > Travis-CI [2] is free for open source as well. [And MIT licensed] > > [Coverity is] closed source though, not sure if that bothers anyone. Faults are faults, so anything coverity catches I think would be nice to see fixes for. If we were to set up our own static analysis infrastructure (which I think would not be a bad idea...), then that's when we'd want to only be looking at open source software options. Bryce > [1]: https://scan.coverity.com/ > [2]: https://travis-ci.org/ > > -- > Mike > > > > > Bryce > > > > > > -- > > cairo mailing list > > [email protected] > > http://lists.cairographics.org/mailman/listinfo/cairo -- cairo mailing list [email protected] http://lists.cairographics.org/mailman/listinfo/cairo