Re: [PATCH] V4 iamge: xlib/xcb backends use filtering to match image backend

Bryce Harrington <[email protected]>
Newsgroups gmane.comp.lib.cairo
Message-ID <[email protected]>
On Fri, Oct 10, 2014 at 06:11:06PM -0700, Bryce Harrington wrote:
> On Thu, Oct 09, 2014 at 07:49:34PM -0700, Bill Spitzak wrote:
> > I ran the tests for the image, xlib, and xcb backends before and
> > after this set of patches. The image backend is unchanged. For
> > xlib/xcb the number of passes increased from 213 to 216, but this
> > includes a number of scaling tests that failed because the reference
> > images do not include filtering:
> 
> Thanks for breaking them up into separate patches, and double thanks for
> checking the test suite.  I've merged these locally and am going to
> re-update the 96:95 ref images (if necessary) and then will push.

Looks like the patchset doesn't change the rendering since my prior
update, so no ref changes appear to be needed.

So with that, this patchset is now merged to trunk.

Thanks,
Bryce
  
> > @@ -74,8 +74,8 @@
> >  clip-fill-rule: FAIL (xlib, xlib-window, xcb, xcb-window, xcb-window&)
> >  a1-clip-fill-rule: PASS
> >  clip-fill-rule-pixel-aligned: PASS
> > -clip-group-shapes-aligned-rectangles: PASS
> > -clip-group-shapes-unaligned-rectangles: FAIL (xlib, xlib-window,
> > xcb, xcb-window, xcb-window&)
> > +clip-group-shapes-aligned-rectangles: FAIL (xlib-render-0_0)
> > +clip-group-shapes-unaligned-rectangles: FAIL (xlib, xlib-window,
> > xlib-render-0_0, xcb, xcb-window, xcb-window&)
> >  clip-group-shapes-circles: FAIL (xlib, xlib-window,
> > xlib-render-0_0, xcb, xcb-window, xcb-window&, xcb-render-0_0)
> >  clip-image: FAIL (xlib, xlib-window, xlib-render-0_0,
> > xlib-fallback, xcb, xcb-window, xcb-window&, xcb-render-0_0)
> >  clip-intersect: FAIL (xlib, xlib-window, xcb, xcb-window, xcb-window&)
> > @@ -139,7 +139,7 @@
> >  device-offset: PASS
> >  device-offset-fractional: FAIL (xlib, xlib-window, xcb, xcb-window,
> > xcb-window&)
> >  device-offset-positive: PASS
> > -device-offset-scale: FAIL (xlib-render-0_0, xlib-fallback, xcb-render-0_0)
> > +device-offset-scale: PASS
> >  error-setters: PASS
> >  extend-pad: PASS
> >  extend-pad-border: FAIL (xlib, xlib-window, xlib-render-0_0,
> > xlib-fallback, xcb, xcb-window, xcb-window&, xcb-render-0_0)
> > @@ -319,10 +319,10 @@
> >  pixman-downscale-fast-24: PASS
> >  pixman-downscale-good-96: PASS
> >  pixman-downscale-good-95: FAIL (xlib, xlib-window, xlib-render-0_0,
> > xlib-fallback, xcb, xcb-window, xcb-window&, xcb-render-0_0,
> > xcb-fallback)
> > -pixman-downscale-good-24: FAIL (xlib-render-0_0, xlib-fallback,
> > xcb-render-0_0)
> > +pixman-downscale-good-24: FAIL (xlib, xlib-window, xlib-render-0_0,
> > xlib-fallback, xcb, xcb-window, xcb-window&, xcb-render-0_0)
> >  pixman-downscale-best-96: PASS
> >  pixman-downscale-best-95: FAIL (xlib, xlib-window, xlib-render-0_0,
> > xlib-fallback, xcb, xcb-window, xcb-window&, xcb-render-0_0,
> > xcb-fallback)
> > -pixman-downscale-best-24: FAIL (xlib-render-0_0, xlib-fallback,
> > xcb-render-0_0, xcb-fallback)
> > +pixman-downscale-best-24: FAIL (xlib, xlib-window, xlib-render-0_0,
> > xlib-fallback, xcb, xcb-window, xcb-window&, xcb-render-0_0,
> > xcb-fallback)
> >  pixman-downscale-nearest-96: PASS
> >  pixman-downscale-nearest-95: PASS
> >  pixman-downscale-nearest-24: PASS
> > @@ -489,10 +489,10 @@
> >  surface-pattern-big-scale-down: PASS
> >  surface-pattern-operator: FAIL (xlib, xlib-window, xlib-render-0_0,
> > xcb, xcb-window, xcb-window&)
> >  surface-pattern-scale-down: FAIL (xlib, xlib-window,
> > xlib-render-0_0, xlib-fallback, xcb, xcb-window, xcb-window&,
> > xcb-render-0_0, xcb-fallback)
> > -surface-pattern-scale-down-extend-repeat: FAIL (xlib-render-0_0,
> > xlib-fallback, xcb-render-0_0)
> > -surface-pattern-scale-down-extend-none: FAIL (xlib, xlib-window,
> > xlib-render-0_0, xlib-fallback, xcb, xcb-window, xcb-window&,
> > xcb-render-0_0)
> > -surface-pattern-scale-down-extend-reflect: FAIL (xlib-render-0_0,
> > xlib-fallback, xcb-render-0_0)
> > -surface-pattern-scale-down-extend-pad: FAIL (xlib-render-0_0,
> > xlib-fallback, xcb-render-0_0)
> > +surface-pattern-scale-down-extend-repeat: PASS
> > +surface-pattern-scale-down-extend-none: FAIL (xlib, xlib-window,
> > xlib-fallback, xcb, xcb-window, xcb-window&)
> > +surface-pattern-scale-down-extend-reflect: PASS
> > +surface-pattern-scale-down-extend-pad: PASS
> >  surface-pattern-scale-up: FAIL (xlib, xlib-window, xlib-render-0_0,
> > xlib-fallback, xcb, xcb-window, xcb-window&, xcb-render-0_0)
> >  text-antialias-gray: PASS
> >  text-antialias-none: PASS
> > @@ -566,17 +566,17 @@
> >  get-xrender-format: PASS
> >  multi-page: UNTESTED
> >  fallback-resolution: UNTESTED
> > -213 Passed, 328 Failed [2 crashed, 4 expected], 23 Skipped
> > +216 Passed, 325 Failed [2 crashed, 4 expected], 23 Skipped
> > -- 
> > cairo mailing list
> > [email protected]
> > http://lists.cairographics.org/mailman/listinfo/cairo
> -- 
> cairo mailing list
> [email protected]
> http://lists.cairographics.org/mailman/listinfo/cairo
-- 
cairo mailing list
[email protected]
http://lists.cairographics.org/mailman/listinfo/cairo
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.