Re: [PATCH 0/2] Update pixman reference images
Bryce Harrington <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <[email protected]> |
On Fri, Oct 10, 2014 at 12:30:29PM -0700, Bill Spitzak wrote: > On 10/10/2014 11:19 AM, Bryce Harrington wrote: > > >Will do. All of these looked fine. The 96:24 BEST cases looked > >legitimately broken but I think that needs separate investigation. > > output/*best-25.*.argb32 are showing some transparency leaking in > from the edges in my examples. Both the argb32 and rgb24 versions > are showing ringing around all the color transitions, but this is > going to happen with such a high-contrast source image. > > The good filter does not produce this ringing. Yeah it sounds like ringing is an inevitable trade-off here. So, should we just mark these tests xfail, or is it worth exploring if we could do better in these corner cases? If the latter, perhaps we need a fairer test? > I think these results are correct though eog likes to show the > transparent leakage as a white edge. If you change it to composite > atop black the edge disappears. I've been using xzgv to view the images, fwiw. > Attached are my results in case you are getting something different. I've unfortunately cleaned up my previous results but I seem to recall seeing something a bit more severe. I'll doublecheck it after I've finished the next weekly test run, tomorrow probably. Thanks, Bryce -- cairo mailing list [email protected] http://lists.cairographics.org/mailman/listinfo/cairo