Re: [PATCH 0/2] Fix cross-endian crashes
Bryce Harrington <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <[email protected]> |
On Fri, Oct 31, 2014 at 12:42:00PM -0700, Bryce Harrington wrote: > On Fri, Oct 31, 2014 at 01:21:13PM -0400, Adam Jackson wrote: > > I'm sure I've sent these before but I don't have the thread handy. As I > > recall, the blocker before was constructing a test case; and no, I don't > > have an easy way to do that, because to do it you'd need to have an X > > server running other-endian from the test. Can we please just inspect the > > code and agree that the fix is correct? > > Looks good to me. > > c being 0 implies that either the height or stride were 0, which means > the second to last arg of the call to xcb_render_add_glyphs and final > arg of the XRenderAddGlyphs call will be zero as well in this case. > Looking at XRenderAddGlyphs's implementation this seems not to be > worrisome. Can't tell offhand what xcb is doing but trust it can handle > it. > > Reviewed-by: Bryce Harrington <[email protected]> > > (Assuming no one objects, I'll land this Monday.) Better late than never I suppose... Both patches landed. adbeb3d..a03f2ff master -> master > > - ajax > > > > -- > > cairo mailing list > > [email protected] > > http://lists.cairographics.org/mailman/listinfo/cairo > -- > cairo mailing list > [email protected] > http://lists.cairographics.org/mailman/listinfo/cairo -- cairo mailing list [email protected] http://lists.cairographics.org/mailman/listinfo/cairo