Re: [PATCH 2/3] Support a different pixel format for HDC

LRN <[email protected]> Tue, 10 Mar 2015 17:52:07 +0300

Newsgroups	gmane.comp.lib.cairo
Message-ID	<[email protected]>

On 17.04.2014 13:46, LRN wrote:
> On 17.04.2014 13:48, Uli Schlachter wrote:
>> On 17.04.2014 11:06, LRN wrote:
>>> Add cairo API to set up a Win32 surface for an HDC with an alpha channel.
>>
>> This adds alpha support to cairo-win32, but doesn't add support for this to the
>> test suite. IMO this should also contain the necessary changes to boilerplate/
>> and contain some information about the test suite results (and compare it to
>> cairo-win32-without-alpha?).
> 
> Yes, that would be awesome.
> 
>>
>>> Signed-off-by: Bas Schouten <[email protected]>
>>
>> I just noticed that your three patches are all signed off by different persons.
>> None of these is you.
> 
> No, one of them is actually from me (the third patch, unsurprisingly).
> 
>> What's up with this? Are we really sure that the original
>> authors are OK with submitting this code to cairo? Why didn't they do so
>> themselves? Where did you find the patches?
> 
> Patch #1 is from cairo bugzilla, see the link you gave me in [1].
> 
> Patch #2 (this patch) was used by Mozilla[2] back in 2010. They have [had?]
> internal copy of cairo to patch, so maybe they just haven't bothered with
> submitting it. Or maybe they did submit it to cairo bugzilla and it got lost
> there. Who knows? Either way, the patch is trivial enough, so i wouldn't
> worry about this one too much.
> 
> 
> [1] http://lists.cairographics.org/archives/cairo/2014-April/025148.html
> [2] https://bugzilla.mozilla.org/show_bug.cgi?id=577200
> 

Any progress on this?

The fallback surface-related crash was fixed in 0.14, so the patch labeled "Enlarge fallback surface" is no longer necessary. I would only need this patch ("Support a different pixel format for HDC") and at least one bit from "Adjust assertions and checks to handle more pixel formats".

These patches are very small, the only prerequisite for being able to evaluate them is understanding of cairo and W32 API. I'd very much like to stop patching cairo and push Windows RGBA code into GTK.

-- 
O< ascii ribbon - stop html email! - www.asciiribbon.org

-- 
cairo mailing list
[email protected]
http://lists.cairographics.org/mailman/listinfo/cairo

0x922360B0.asc (application/pgp-keys, 1.7 KB)

-----BEGIN PGP PUBLIC KEY BLOCK-----
Version: GnuPG v1.4.11 (MingW32)

mQENBE48DHkBCADjAv/EeFMN+i5XDN2WjSBU/yHbJlIG93/Hpj7Hee65qr82O9us
n3t4W1bk2+YwGBrFdfVlesHF4DObckXveayC+IulVvTJwZhR8igVENvWjIo6oF1N
1B3GV/c8zVCnHdkF0+vYJ9akX6DZf8KvBqKZapK1kc3tll0o+kS9lwNfpWRarUpQ
SBTw2uq+FUEsO3pwVAyvwom4b7AB6fz1tpyl28dOaNDKr2W55ZDPC8aM5PPe/kiH
n3ylOwpgXYqZLhIyJStqL/KcZ76y8o/gDXnilFRLwXu9CbXjapo7MARXByuSVMfb
PHa3XNj5JCzlv4GhEF4HOp4qoVRk8YASTqf/ABEBAAG0F0xSTiA8bHJuMTk4NkBn
bWFpbC5jb20+iQE9BBMBAgAnAhsjBQkJZgGAAh4BAheABQJT5qxpBQsJCAcDBRUK
CQgLBRYCAwEAAAoJEOs4Jb6SI2CwBNMIAKu3L9CGoTlJHZ/0G5AbbcP9zeiIkKkN
yvi1XszHiDz1kaESQYjpDsEWeHQutEhmnK5DNRyA6VV7Tcc49+1luq5Uf1kb8gGr
2mbF+eLG0Rv/WGoi/Aa4eH7K9dH2BSOUn+eX3Ft/HbBp9ZWCBRnABuO4oKmS+zfd
O9wMaQJkRRnwo151TNVMpWIO/kE7t4YeJyV/fUdYsMzlH53hzXnCM5DQ3ovje7NI
0prrSaqrthS0W5ELKZnb7PDY7pII0xh5/+u+f9Vs0mdMjvYZT42DiJnHvtfLEo1h
7KwLkC1lltZ/eaQOKFAszDzi2KoilSY/29mK7wLCd1TFJjklJNQqyxu5AQ0ETjwM
eQEIAKpvqHog2hpurRnsF6IKQtqR7JXYie9mvNoPW7XWmN3TtkHp5zrUG4SkR4dU
CTXxO82kMlwC94s79YJNTr30fahW6BVe72aZ+1D5qJcHk0CeHj56lri2kPOxyZXo
19Rhw43YtGZNvkNOg5xmMIzxUbMnxRTSppEFi0YQ+cCjnQksHiQPcCsb5bow53Ii
M9pICELT0d3nB5iDFCQb3oiXdRitDJJtZ97vOUE+xpUeYTcHXZyLmXYyMA7cFa/b
wRwj/5xofXYE0WlnHDn+0QOTf1BOGaWH1eZqYYBVKegKXW65Y7UOU4f0pZQUQ+FQ
wbwnSDlFuJPKA5MDgDczqtAVtNsAEQEAAYkBJQQYAQIADwUCTjwMeQIbDAUJCWYB
gAAKCRDrOCW+kiNgsJ2FCACaycPmmvwar2FwTbT+/OFM9rt9KQ6JCldNSePGNzHE
k0WBu5HyzgGcuOqoQSIwPHGnu2zkZl0PMW/WW9648a4OBuK08zNmypHXQw3fG0nG
KNsO6j86tOLINS6p/P4vMcF8Fz6ZdIwSj8oXnuku0C0nkLB/ja/VZk1wcI30ulJF
A2EhgLWIXZaTBlWR4KitGiGL7yzpUzBarPE8YFZLF+rfqu7NlxeG3NbBA/5UmH6r
FL5Cva/ajOJW2CtGyuROTYhqBfolxZtfSHHj1wOAlc+dA0utIW4NDbIyZxCoxDTF
/lUIjgj/Xu0IRIsX5m6TbBl40LH81JI0g1750FJfP4de
=aWCf
-----END PGP PUBLIC KEY BLOCK-----

signature.asc (application/pgp-signature, 488 B)

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (MingW32)

iQEcBAEBAgAGBQJU/wUcAAoJEOs4Jb6SI2Cw12EIAIOpMKDijD30Doqx//1MVKyk
bx3utifoGQHYcT/5MybkH07pW+TiJvKBUK/z30vnINY+mXhXFLeIhYwOZpx4LhXf
uy8tPoagwe7W9F2Yp9d67WkiV3dBHvmXMnPA98dBR4Uy4Ekhi1EczcvAmzUF9KFw
DDqAbkzz3ILFKMS0DzuLE6RsrN1KpnsCDy/jSnPXwVvXdCPYv4uH2uwz5gjmvXy0
sTqxi1aYSxl06ml8YVfrcemnXW6g+rHDw10NNTQansy53mcgbTd0ZzbV+IHMF/Gd
SYBJgHyPEtJADSfHNiqm9DV6Wux4ivp1+ta/3jFuhtGnPYv8CQfenHdH2P/lbaA=
=gurt
-----END PGP SIGNATURE-----