Re: [PATCH] Fix Windows build with cmd.exe as shell

Simon Richter <[email protected]> Fri, 24 Apr 2015 00:27:52 +0200

Newsgroups	gmane.comp.lib.cairo
Message-ID	<[email protected]>

Hi,

On 23.04.2015 23:42, Bryce Harrington wrote:

>> No, the call is needed because I need to process the arguments (md and
>> del do not handle forward slashes and echo needs a dot to print a
>> newline instead of "@ECHO is off".

> Well, in any case, the hacky looking echo statements that the call
> syntax creates makes the patch kind of a non-starter for me.  The goal
> sounds noble enough though, so I'd consider another patch that was less
> invasive.

The bulk of the patch is in an automatically generated file that creates
a file on demand, this entire construct could be replaced by simply
copying a file into place.

The remaining instances are messages printed to the console, this could
be hacked around using $(info ...) and a sub-make -- but I think that is
even worse.

The difference in quote handling would only allow writing the messages
surrounded by quotes, and these could be arranged to form a frame around
the message.

For the directory creation and file deletion I don't see a way around
the call syntax though, because of the processing required.

   Simon

-- 
cairo mailing list
[email protected]
http://lists.cairographics.org/mailman/listinfo/cairo

signature.asc (application/pgp-signature, 473 B)