Re: [PATCH] cairo-recording-surface: Fix loss of alpha when clipping

On Thu, Jun 25, 2015 at 07:01:08PM -0700, Bryce Harrington wrote:
> Commit 8020e0bc introduced a regression due to a typo when copying a
> mask for a cairo recording surface.  It should copy the source and mask
> members from the command source to the recording surface, but instead it
> copies the source twice.
> 
> Fix suggested by Massimo.
>
> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=73038
> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=73901
> Signed-off-by: Bryce Harrington <[email protected]>

su_v tested the patch and found it also solved some Inkscape
regressions.

Pushed
   c1c3028..1bcce43  master -> master

Bryce

> ---
>  src/cairo-recording-surface.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/cairo-recording-surface.c b/src/cairo-recording-surface.c
> index ce29b93..78e7cfa 100644
> --- a/src/cairo-recording-surface.c
> +++ b/src/cairo-recording-surface.c
> @@ -1165,7 +1165,7 @@ _cairo_recording_surface_copy__mask (cairo_recording_surface_t *surface,
>  	goto err_command;
>  
>      status = _cairo_pattern_init_copy (&command->mask.base,
> -				       &src->mask.source.base);
> +				       &src->mask.mask.base);
>      if (unlikely (status))
>  	goto err_source;
>  
> -- 
> 1.9.1
-- 
cairo mailing list
[email protected]
http://lists.cairographics.org/mailman/listinfo/cairo