Re: [PATCH] test: Always use DejaVu Sans as default font
Lawrence D'Oliveiro <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Organization | Geek Central |
| Message-ID | <[email protected]> |
On Mon, 6 Jul 2015 14:24:54 -0700, Bryce Harrington wrote: > On Thu, Jul 02, 2015 at 11:52:15AM +0200, Andrea Canciani wrote: > >> On Thu, Jul 2, 2015 at 12:05 AM, Lawrence D'Oliveiro < >> [email protected]> wrote: >> >>> On Wed, 1 Jul 2015 12:00:49 +0200, Andrea Canciani wrote: >>> >>>> This change should not affect Linux environments, assuming that >>>> the default font is already set to "DejaVu Sans". >>> >>> On Linux environments, I would expect to see Fontconfig in use. >>> This can take a generic name like “Sans Serif” and map it to >>> whatever font the user desires. >> >> Yes, but (for the test suite) if this happens you are likely already >> getting failures when you test cairo, because unless the >> user-chosen font glyphs have the same shape as the DejaVu Sans >> ones, the output of the test cases will not match the reference. >> Please notice that most tests already set the font to >> CAIRO_TEST_FONT_FAMILY " ...". > > Right, for the test suite, there is no user to have desires. :-) > Goal is to just make sure results match up to the references. However, even a specific-sounding name like “DejaVu Sans” can be remapped by Fontconfig. If a test suite can be led astray by vagaries of user configuration, then isn’t that a bug in the test suite? If you want to depend on a specific font in the test suite, then the font needs to be included in the test suite. -- cairo mailing list [email protected] http://lists.cairographics.org/mailman/listinfo/cairo