Re: [PATCH] gl: Fix incorrect size of expression

On Mon, Jul 13, 2015 at 11:31:48AM +0530, Arpit Jain wrote:
>         The sizeof operator now applied to the correct variable "ctx->glyph_cache",
> 	instead of its pointer variable, in function "_cairo_gl_composite_flush".
> 
>    	Fixes:  https://bugs.freedesktop.org/show_bug.cgi?id=91321
> 
> Signed-off-by: Arpit Jain <[email protected]>
Reviewed-by: Bryce Harrington <[email protected]>

Good find, pushed.
To ssh://git.cairographics.org/git/cairo
   498fc2f..edd321c  master -> master

Btw, your commit messages are indented but should be flush left.  I've
been fixing them when applying your patches, but you might check your
editor settings.

> ---
>  src/cairo-gl-composite.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/cairo-gl-composite.c b/src/cairo-gl-composite.c
> index b50f9a7..5b14114 100644
> --- a/src/cairo-gl-composite.c
> +++ b/src/cairo-gl-composite.c
> @@ -861,7 +861,7 @@ _cairo_gl_composite_flush (cairo_gl_context_t *ctx)
>  	_cairo_gl_composite_draw_triangles_with_clip_region (ctx, count);
>      }
>  
> -    for (i = 0; i < ARRAY_LENGTH (&ctx->glyph_cache); i++)
> +    for (i = 0; i < ARRAY_LENGTH (ctx->glyph_cache); i++)
>  	_cairo_gl_glyph_cache_unlock (&ctx->glyph_cache[i]);
>  }
>  
> -- 
> 1.7.9.5
> 
> 
> -- 
> cairo mailing list
> [email protected]
> http://lists.cairographics.org/mailman/listinfo/cairo
-- 
cairo mailing list
[email protected]
http://lists.cairographics.org/mailman/listinfo/cairo