Re: [PATCH 14/41] drm/intel: intel_scaled_glyph_fini(): renamed local priv variable for better consistency
Uli Schlachter <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <[email protected]> |
Am 12.12.2015 um 06:23 schrieb Enrico Weigelt, metux IT consult: > On 11.12.2015 17:51, Uli Schlachter wrote: > >> Uhm, this patch doesn't do at all what the commit message claims it does. I >> don't see why removing this NULL check is safe and I think it's the more >> important change than renaming the variable[0]. > > It's just to make it more consistent with the naming scheme used in > other backends (eg. gl). I've done it in a separate patch to keep the > individual changes small, for easier review (and later reading) I can see that, yeah. However, this still removes the if (glyph != NULL) check that was there before (should be priv != NULL after this patch, no?). Uli -- Bruce Schneier can read and understand Perl programs. -- cairo mailing list [email protected] http://lists.cairographics.org/mailman/listinfo/cairo