Re: [PATCH 14/41] drm/intel: intel_scaled_glyph_fini(): renamed local priv variable for better consistency
Uli Schlachter <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <[email protected]> |
Am 12.12.2015 um 18:03 schrieb Enrico Weigelt, metux IT consult:
> On 12.12.2015 10:53, Uli Schlachter wrote:
>
>> I can see that, yeah. However, this still removes the if (glyph != NULL) check
>> that was there before (should be priv != NULL after this patch, no?).
>
> That check was also missing in the other backends I used as templates
> (eg. GL)
>
> Should we add it there, too ?
I'd guess that if other backends don't have it, it isn't necessary. I don't
know. My complaint was only about the patch doing not exactly what its commit
message says.
--
A learning experience is one of those things that say,
'You know that thing you just did? Don't do that.'
-- Douglas Adams
--
cairo mailing list
[email protected]
http://lists.cairographics.org/mailman/listinfo/cairo