Re: [PATCH 12/43] drm: allow CAIRO_FORMAT_RGB30
Lawrence D'Oliveiro <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Organization | Geek Central |
| Message-ID | <[email protected]> |
On Wed, 16 Dec 2015 12:02:34 +0100, Enrico Weigelt, metux IT consult wrote: > On 15.12.2015 21:20, Lawrence D'Oliveiro wrote: > >> On Tue, 15 Dec 2015 20:49:52 +0100, Enrico Weigelt, metux IT consult >> wrote: >> >>> + case CAIRO_FORMAT_RGB30: >>> cache->buffer.map0 = MAPSURF_32BIT | MT_32BIT_ARGB8888; >> >> I assume the code is not actually looking at the pixel components, >> otherwise this cannot be correct. > > Well, I'm a bit naive at this point - I just assmed that on RGB30 > the upper two bits are just zero (and it's still 4 byte per pixel) > > OTOH, we could just declare rgb30 as unsupported. > What's your oppinion ? I don’t know anything about Linux DRM. :) I just saw “MT_32BIT_ARGB8888” and thought “that’s not what RGB30 means”. If all it means is “4 bytes per pixel” (and doesn’t look at how the components are divided up), then fine. -- cairo mailing list [email protected] http://lists.cairographics.org/mailman/listinfo/cairo