Re: [PATCH 11/51] core: dropped unnecessary local variable in _cairo_composite_rectangles_intersect()

Bryce Harrington <[email protected]>
Newsgroups gmane.comp.lib.cairo
Message-ID <[email protected]>
On Fri, Dec 18, 2015 at 02:28:50PM +0100, Enrico Weigelt, metux IT consult wrote:
> Signed-off-by: Enrico Weigelt, metux IT consult <[email protected]>

LGTM

Reviewed-by: Bryce Harrington <[email protected]>
> ---
>  src/cairo-composite-rectangles.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/src/cairo-composite-rectangles.c b/src/cairo-composite-rectangles.c
> index 495d200..bc6e1f3 100644
> --- a/src/cairo-composite-rectangles.c
> +++ b/src/cairo-composite-rectangles.c
> @@ -146,10 +146,8 @@ static cairo_int_status_t
>  _cairo_composite_rectangles_intersect (cairo_composite_rectangles_t *extents,
>  				       const cairo_clip_t *clip)
>  {
> -    cairo_bool_t ret;
> -
> -    ret = _cairo_rectangle_intersect (&extents->bounded, &extents->mask);
> -    if (! ret && extents->is_bounded & CAIRO_OPERATOR_BOUND_BY_MASK)
> +    if ((!_cairo_rectangle_intersect (&extents->bounded, &extents->mask)) &&
> +        (extents->is_bounded & CAIRO_OPERATOR_BOUND_BY_MASK))
>  	return CAIRO_INT_STATUS_NOTHING_TO_DO;
>  
>      if (extents->is_bounded == (CAIRO_OPERATOR_BOUND_BY_MASK | CAIRO_OPERATOR_BOUND_BY_SOURCE)) {
> -- 
> 2.6.4.442.g545299f
> 
> -- 
> cairo mailing list
> [email protected]
> http://lists.cairographics.org/mailman/listinfo/cairo
-- 
cairo mailing list
[email protected]
http://lists.cairographics.org/mailman/listinfo/cairo
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.