Re: [PATCH 12/51] core: changed retval of _cairo_composite_rectangles_intersect() to cairo_bool_t
"Enrico Weigelt, metux IT consult" <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <[email protected]> |
On 22.12.2015 23:41, Bryce Harrington wrote: > On Fri, Dec 18, 2015 at 02:28:51PM +0100, Enrico Weigelt, metux IT consult wrote: >> This function only has two possible return states - success and >> nothing to do. We just need 1 bit for that. Replacing the big enum >> by bool makes the code smaller and easier to understand (dont need to >> consider other possible values of cairo_int_state_t anymore) >> >> The same applies to several callers - they'll be changed in subsequent patches. > > Not a thorough review, but if switching to cairo_bool_t, then return > TRUE/FALSE rather than 0/1. Okay, changed it. --mtx -- cairo mailing list [email protected] http://lists.cairographics.org/mailman/listinfo/cairo