Re: [PATCH 05/51] core: helper function for converting cairo_status_t to human-readable text (like strerror)
Chris Wilson <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Dec 23, 2015 at 12:31:32AM +0100, Enrico Weigelt, metux IT consult wrote: > On 22.12.2015 23:19, Bryce Harrington wrote: > > > The function is defined as returning a const char*, so printing a > > textual string rather than a number is what it should be doing. > > Right. The printed numbers are just fallback, so we have at least > *something* if we hit an undefined number (which should never happen) Right, we assert. Kill the bug at source. If code review can't spot it, the test cases can't hit it, we haven't been doing a very good job at validating the code. -Chris -- Chris Wilson, Intel Open Source Technology Centre -- cairo mailing list [email protected] http://lists.cairographics.org/mailman/listinfo/cairo