Re: [PATCH 19/72] drm: use typedefs and defines from drm headers instead of redundant own definitions
"Enrico Weigelt, metux IT consult" <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <[email protected]> |
On 29.12.2015 17:05, Chris Wilson wrote: > On Tue, Dec 29, 2015 at 10:16:57AM +0100, Enrico Weigelt, metux IT consult wrote: >> These typedefs and defines are part of the libdrm API and therefore should >> be taken from there, instead of own redundant declarations. > > What? They are not all part of libdrm API (and do not even contemplate > using libdrm_intel). They are part of the kernel ABI though. Well, they originally come from the kernel, but libdrm has an own copy. Actually, we'll need to include it from libdrm instead of the kernel, as there're subtle differences, which cause other libdrm includes (xf86drm*.h) to break when using the kernel headers. --mtx -- Enrico Weigelt, metux IT consulting +49-151-27565287 -- cairo mailing list [email protected] http://lists.cairographics.org/mailman/listinfo/cairo