Re: [PATCH] add "surface_transform" parameter to "replay_and_create_regions" function
Bryce Harrington <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <[email protected]> |
On Thu, Dec 31, 2015 at 01:54:37PM +0100, Guillaume Ayoub wrote: > Hi, > > I have tried twice to send a patch in 2013, but nobody answered :(. > > Here is the description of the patch: > > > This patch adds a "surface_transform" parameter to the > "replay_and_create_regions" function. > > > > It was already done in surface_replay_with_clip, as the matrix is > obviously needed for the clip. But now, because of the optimization > done in commit 09b42c7, it's also needed by > replay_and_create_regions: get_target_extents clips the target > surface for performance issues, and therefore needs the > surface_transform matrix to get the right clipping surface. > > I can provide further information if needed. Please let me know if > there's anything wrong with this patch, or if I can do anything to > make it find its way to the repository. > > The patch is available here: > http://lists.cairographics.org/archives/cairo/2013-May/024301.html > > The bug have been introduced in commit 09b42c7: > http://cgit.freedesktop.org/cairo/commit/?id=09b42c7 > > An example of what this bug causes have been reported here: > https://github.com/Kozea/WeasyPrint/issues/278 > > Thank you, and happy new year! I would suggest using git format-patch and git send-mail to post patches. There's some good tips on effective patch submission here: http://wiki.x.org/wiki/Development/Documentation/SubmittingPatches/ Bryce -- cairo mailing list [email protected] http://lists.cairographics.org/mailman/listinfo/cairo