Re: [PATCH] Pull -lz for the script backend

On 12/08/16 22:38, Enrico Weigelt, metux IT consult wrote:
> On 12.08.2016 11:04, Olivier Blin wrote:
> 
>>> Looks like this would silently disable the script backend if libz
>>> is missing. IMHO, a very bad idea - instead it should break with a
>>> proper error message.
>> This is actually copy/paste of what is already properly done for the
>> PostScript and PDF backends.
>>
>> CAIRO_ENABLE_SURFACE_BACKEND(pdf, PDF, yes, [
>>     # The pdf backend requires zlib.
>>     use_pdf=$have_libz
>>     pdf_NONPKGCONFIG_LIBS=-lz
>> ])
> 
> Right, there seems to be the same problem.
> I'd suggest emitting an error here.

Looking at the macro definition it appears to emit an error if a feature
is enabled without the required dependencies.

build/aclocal.enable.m4 lines 88 to 96:

  AS_IF([test "x$enable_$1" = "xyes" -a "x$use_$1" != xyes],
  [dnl
      AC_MSG_ERROR(
      m4_case(cr_feature_default,
          [always],	[mandatory],
          [yes],		[recommended],
          ,		[requested]
    ) cr_feature_name[ feature could not be enabled])
  ])dnl

> 
> 
> --mtx
> 

-- 
cairo mailing list
[email protected]
https://lists.cairographics.org/mailman/listinfo/cairo