Re: [PATCH] Pull -lz for the script backend

Adrian is right.  Original patch lgtm.

(i just remembered how much fun I had writing those macros...:-)

On Aug 30, 2016 3:28 PM, "Adrian Johnson" <[email protected]> wrote:

> On 31/08/16 06:38, Bryce Harrington wrote:
> > On Fri, Aug 12, 2016 at 03:48:57PM +0200, Olivier Blin wrote:
> >> Le 12/08/2016 à 15:08, Enrico Weigelt, metux IT consult a écrit :
> >>> On 12.08.2016 11:04, Olivier Blin wrote:
> >>>
> >>>>> Looks like this would silently disable the script backend if libz
> >>>>> is missing. IMHO, a very bad idea - instead it should break with a
> >>>>> proper error message.
> >>>> This is actually copy/paste of what is already properly done for the
> >>>> PostScript and PDF backends.
> >>>>
> >>>> CAIRO_ENABLE_SURFACE_BACKEND(pdf, PDF, yes, [
> >>>>     # The pdf backend requires zlib.
> >>>>     use_pdf=$have_libz
> >>>>     pdf_NONPKGCONFIG_LIBS=-lz
> >>>> ])
> >>>
> >>> Right, there seems to be the same problem.
> >>> I'd suggest emitting an error here.
> >> Ok, but this is a separate issue that was already present in the
> >> previous configure file.
> >> This can be fixed regardless of this patch.
> >>
> >> Thanks for your input
> >
> > Would you mind sending a 2-patch set that fixes both issues for us?
>
> There is no problem with this patch.
>
> https://lists.cairographics.org/archives/cairo/2016-August/027701.html
>
> >
> > Thanks,
> > Bryce
> >
> >> --
> >> Olivier Blin - SoftAtHome
> >>
> >> --
> >> cairo mailing list
> >> [email protected]
> >> https://lists.cairographics.org/mailman/listinfo/cairo
>
> --
> cairo mailing list
> [email protected]
> https://lists.cairographics.org/mailman/listinfo/cairo

-- 
cairo mailing list
[email protected]
https://lists.cairographics.org/mailman/listinfo/cairo