Re: [PATCH] Add example to run specific tests by name to the test/README

On Wed, Jul 27, 2016 at 06:38:17PM +0200, Uli Schlachter wrote:
> Am 26.07.2016 um 19:38 schrieb Darxus:
> > ---
> >  test/README | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/test/README b/test/README
> > index 8cf3ddb..155310a 100644
> > --- a/test/README
> > +++ b/test/README
> > @@ -21,8 +21,9 @@ The test suite needs to be run before any code is committed and before
> >  any release. See below for hints and rules governing the use of the suite.
> >  
> >  The test suite is built as a single binary, which allows you to choose
> > -individual or categories of tests to run. For example, if you want to
> > -run all text related tests you can use:
> > +individual or categories of tests to run. For example, to run specific tests:
> > +    ./cairo-test-suite record-neg-extents-unbounded record-neg-extents-bounded
> > +Or if you want to run all text related tests you can use:
> >      ./cairo-test-suite text
> >  Or if you want to check the current status of known failures:
> >      ./cairo-test-suite XFAIL
> 
> This definitely improves the current state, so:
> 
> Reviewed-by: Uli Schlachter <[email protected]>

LGTM too,

Reviewed-by: Bryce Harrington <[email protected]>
 
> However, the following example is wrong. "./cairo-test-suite text" doesn't run
> anything. Should it be "./cairo-test-suite -k text"?

No, there's a separate example for using -k for keywords.  This example
seems to be there to show that cairo-test-suite does partial matching
against test names.  'paint' would be better though, that's more core
and the tests pass (for me anyway).  I.e.:

  Or if you want to run all paint.* related tests you can use:
      ./cairo-test-suite paint

Hope you don't mind Darxus, I'll just piggyback this on your patch and
land it with Uli and my R-b.

Pushed:
   66205ad..cbbd02f  master -> master


Bryce
-- 
cairo mailing list
[email protected]
https://lists.cairographics.org/mailman/listinfo/cairo