Re: [PATCH] image: prevent invalid ptr access for > 4GB images
Petr Kobalíček <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <CAB2Z3OdhcwwT1U_5KaNoO=T0b8sE3Tcon69OHuLrqom_x5N6sQ@mail.gmail.com> |
I meant `cairo_format_stride_for_width()` has no knowledge about the height. On Thu, Mar 9, 2017 at 5:23 PM, Petr Kobalíček <[email protected]> wrote: > Since `cairo_format_stride_for_width()` has no knowledge about the width > it cannot return -1 in case that stride * height would overflow. I think > this must be checked. > > On Thu, Mar 9, 2017 at 12:01 PM, Adrian Johnson <[email protected]> > wrote: > >> I wrote this patch [1] for bug 98165 last year. I found it is also >> needed to fix a poppler bug [2]. Any objections to pushing it? >> >> [1] https://bugs.freedesktop.org/show_bug.cgi?id=98165#c6 >> [2] https://bugs.freedesktop.org/show_bug.cgi?id=100056 >> >> >> -- >> cairo mailing list >> [email protected] >> https://lists.cairographics.org/mailman/listinfo/cairo >> > > -- cairo mailing list [email protected] https://lists.cairographics.org/mailman/listinfo/cairo