Re: OpenType font variations and cairo

Yeah, I think a configure.ac check and strtod_l() is best.  I'll do that in
HarfBuzz.

On Thu, Sep 14, 2017 at 4:59 PM, Matthias Clasen <[email protected]>
wrote:

> On Thu, Sep 14, 2017 at 5:54 PM, Adrian Johnson <[email protected]>
> wrote:
>
>> On 15/09/17 05:52, Matthias Clasen wrote:
>> > On Thu, Sep 14, 2017 at 12:37 PM, Behdad Esfahbod
>> > <[email protected] <mailto:[email protected]>> wrote:
>> >
>> >     Thanks Matthias.  I took a look at the patch.  Looks good!  Minor
>> >     comments:
>> >
>> >     - Moving the format towards CSS by default (no comma, no equal sign;
>> >     just spaces!) while accepting both is what I do in HarfBuzz. Maybe
>> >     advertise the same here,  UPDATE: I was wrong.  CSS uses comma as
>> >     well.  It's the equal sign that they don't use, they use space.  We
>> >     should accept both.
>> >
>> >
>> > I've made the parser a bit more flexible. It now accepts variations like
>> >
>> > wdth=200,wght=300
>> > wdth 200, wght=300
>> > wdth 200 , wght 300
>>
>> Does it work with decimal commas?
>>
>
> The patch currently uses strtod, so yes, it will parse floating point
> numbers, but decimal separators spell trouble.
> I could rewrite it to use strtod_l, if that is ok to use in cairo.
>
> --
> cairo mailing list
> [email protected]
> https://lists.cairographics.org/mailman/listinfo/cairo
>



-- 
behdad
http://behdad.org/

-- 
cairo mailing list
[email protected]
https://lists.cairographics.org/mailman/listinfo/cairo