Re: [PATCH] Fix a 'memory leak' in the image compositor
Uli Schlachter <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <[email protected]> |
On 19.01.2018 00:54, Bryce Harrington wrote: > On Sat, Jan 13, 2018 at 02:49:52PM +0100, Uli Schlachter wrote: >> There is a global pixman_glyph_cache_t instance that is initialized on >> first use and shows up in valgrind output as a relatively large leak (I >> think it was about 200 KiB). The reason for this is that this cache is >> not freed by cairo_debug_reset_static_data(). >> >> This commit wires up freeing the cache to >> cairo_debug_reset_static_data(). >> >> This cache was introduced in commit 615205cf0729 from 2012. >> >> Signed-off-by: Uli Schlachter <[email protected]> > > Offhand looks good to me. Have you run this against the test suite? Not really, no. I think I only ran this against one specific test to see if valgrind is content. Any reason that you expect this to go wrong? Uli -- - He wants the impossible...! - That's the short definition of 'captain'. -- cairo mailing list [email protected] https://lists.cairographics.org/mailman/listinfo/cairo